Fix pagination links for Orders pagination wrt the use of overriding url_for#124
Merged
philvarner merged 16 commits intomainfrom Dec 17, 2025
Merged
Fix pagination links for Orders pagination wrt the use of overriding url_for#124philvarner merged 16 commits intomainfrom
philvarner merged 16 commits intomainfrom
Conversation
added 6 commits
December 3, 2025 10:08
jkeifer
reviewed
Dec 10, 2025
jkeifer
reviewed
Dec 12, 2025
added 6 commits
December 15, 2025 19:55
…pace before tests
Collaborator
|
Test comment for @philvarner |
wevonosky
reviewed
Dec 17, 2025
wevonosky
reviewed
Dec 17, 2025
wevonosky
reviewed
Dec 17, 2025
wevonosky
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I'm changing
Currently, the pagination links for Orders and Order Statuses don't have
nextlink relation hrefs with the value returned from url_for, so they're always relative to the server's URL (default) rather than what the implementation has overridden url_for to do.How I did it
Checklist
uv run pytestuv run pre-commit run --all-files